Encapsulate border radius resolution logic#43983
Closed
NickGerleman wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55635743 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55635743 |
NickGerleman
force-pushed
the
export-D55635743
branch
from
cb81fa0 to
801af89
Compare
Base commit: c3d4574 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55635743 |
NickGerleman
force-pushed
the
export-D55635743
branch
from
801af89 to
407a77f
Compare
Differential Revision: D55565035
Differential Revision: D55563775
Summary: Pull Request resolved: facebook#43983 We duplicate some pretty hairy code related to conversion between logical and physical edges, along with the grafting between uniform and non uniform radii. This encapsulates border radius resolution/assignment logic. Changelog: [Internal] Differential Revision: D55635743
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55635743 |
NickGerleman
force-pushed
the
export-D55635743
branch
from
407a77f to
08ed203
Compare
Contributor
|
This pull request has been merged in c710386. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We duplicate some pretty hairy code related to conversion between logical and physical edges, along with the grafting between uniform and non uniform radii. This encapsulates border radius resolution/assignment logic.
Changelog: [Internal]
Differential Revision: D55635743